If you prefer a quick overview, 1 day for Terracotta Warriors tour is enough.  2-3 days is perfect for fully exploring Xi’an and 4 days is suitable for deeper exploring in Xi’an.